Fix a nullptr dereferencing in a FuncBufferizableOpInterfaceImpl.cpp::getCalledFunction
#150518
Conversation
…::getCalledFunction`
|
Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it is probably because you do not have write permissions for the repository. In which case you can instead tag reviewers by name in a comment by using If you have received no comments on your PR for a week, you can request a review by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate is once a week. Please remember that you are asking for valuable time from other developers. If you have further questions, they may be answered by the LLVM GitHub User Guide. You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums. |
|
@llvm/pr-subscribers-mlir-bufferization Author: Paul (paul0403) ChangesThere is a potential nullptr dereferencing in the helper function Fixes issue #150441 Full diff: https://github.com/llvm/llvm-project/pull/150518.diff 1 Files Affected:
diff --git a/mlir/lib/Dialect/Bufferization/Transforms/FuncBufferizableOpInterfaceImpl.cpp b/mlir/lib/Dialect/Bufferization/Transforms/FuncBufferizableOpInterfaceImpl.cpp
index 2a98203da9d7d..ac0ef0edb0438 100644
--- a/mlir/lib/Dialect/Bufferization/Transforms/FuncBufferizableOpInterfaceImpl.cpp
+++ b/mlir/lib/Dialect/Bufferization/Transforms/FuncBufferizableOpInterfaceImpl.cpp
@@ -90,8 +90,9 @@ static FuncOp getCalledFunction(CallOpInterface callOp,
const AnalysisState &state) {
auto &oneShotAnalysisState = static_cast<const OneShotAnalysisState &>(state);
- if (auto *funcAnalysisState =
- oneShotAnalysisState.getExtension<FuncAnalysisState>()) {
+ auto *funcAnalysisState =
+ oneShotAnalysisState.getExtension<FuncAnalysisState>();
+ if (funcAnalysisState != nullptr) {
// Use the cached symbol tables.
return getCalledFunction(callOp, funcAnalysisState->symbolTables);
}
|
|
@llvm/pr-subscribers-mlir Author: Paul (paul0403) ChangesThere is a potential nullptr dereferencing in the helper function Fixes issue #150441 Full diff: https://github.com/llvm/llvm-project/pull/150518.diff 1 Files Affected:
diff --git a/mlir/lib/Dialect/Bufferization/Transforms/FuncBufferizableOpInterfaceImpl.cpp b/mlir/lib/Dialect/Bufferization/Transforms/FuncBufferizableOpInterfaceImpl.cpp
index 2a98203da9d7d..ac0ef0edb0438 100644
--- a/mlir/lib/Dialect/Bufferization/Transforms/FuncBufferizableOpInterfaceImpl.cpp
+++ b/mlir/lib/Dialect/Bufferization/Transforms/FuncBufferizableOpInterfaceImpl.cpp
@@ -90,8 +90,9 @@ static FuncOp getCalledFunction(CallOpInterface callOp,
const AnalysisState &state) {
auto &oneShotAnalysisState = static_cast<const OneShotAnalysisState &>(state);
- if (auto *funcAnalysisState =
- oneShotAnalysisState.getExtension<FuncAnalysisState>()) {
+ auto *funcAnalysisState =
+ oneShotAnalysisState.getExtension<FuncAnalysisState>();
+ if (funcAnalysisState != nullptr) {
// Use the cached symbol tables.
return getCalledFunction(callOp, funcAnalysisState->symbolTables);
}
|
| oneShotAnalysisState.getExtension<FuncAnalysisState>()) { | ||
| auto *funcAnalysisState = | ||
| oneShotAnalysisState.getExtension<FuncAnalysisState>(); | ||
| if (funcAnalysisState != nullptr) { |
There was a problem hiding this comment.
Maybe change to:
if (!funcAnalysisState)
And please add a test.
| @@ -90,8 +90,9 @@ static FuncOp getCalledFunction(CallOpInterface callOp, | |||
| const AnalysisState &state) { | |||
| auto &oneShotAnalysisState = static_cast<const OneShotAnalysisState &>(state); | |||
|
|
|||
| if (auto *funcAnalysisState = | |||
| oneShotAnalysisState.getExtension<FuncAnalysisState>()) { | |||
| auto *funcAnalysisState = | |||
There was a problem hiding this comment.
Does this really fix the issue?
auto *x = abc();
if (x != nullptr) foo();
is identical to
if (auto *x = abc()) foo();
There was a problem hiding this comment.
I think you are right, I need to investigate the segfault more. Maybe this is not where the root cause is...
There is a potential nullptr dereferencing in the helper function
getCalledFunctionwhen bufferizing call ops.The solution is making the nullptr check explicit before dereferencing it.
Fixes #150441.